Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add logging to ErrorController #242

Open
oliverhummel opened this issue Sep 20, 2021 · 1 comment
Open

Please add logging to ErrorController #242

oliverhummel opened this issue Sep 20, 2021 · 1 comment
Assignees
Labels
back end bad ux UX = User eXperience ;-) high priority

Comments

@oliverhummel
Copy link
Contributor

oliverhummel commented Sep 20, 2021

in de.hs_mannheim.informatik.ct.controller

Use @slf4j and log.error... to add logging for each error that may occur, otherwise tracing errors from the log is impossible.

Especially the cause for the anyException should be logged: add Exception as a param to the method and log the exception, pls.

And at this occasion also remove the Sysout in line 125.

Made PR #243 for an example. (probably the other methods do not need a full stack trace).

@oliverhummel oliverhummel added bad ux UX = User eXperience ;-) back end high priority labels Sep 20, 2021
@oliverhummel
Copy link
Contributor Author

oliverhummel commented Sep 22, 2021

Since most methods here are copy and paste, the whole class could be shrunk to three methods when all exceptions inherited from one common super class such as CttException and use the same handling method then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back end bad ux UX = User eXperience ;-) high priority
Projects
None yet
Development

No branches or pull requests

2 participants