-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All synonym types defined as oboInOwl:SynonymType
but historically they're defined as oboInOwl:SynonymTypeProperty
#157
Comments
oboInOwl:SynonymType
but historically they're defined as oboInOwl:SynonymTypeProperty
`oboInOwl:SynonymType
but historically they're defined as oboInOwl:SynonymTypeProperty
Wow. Which of the two is the correct one, I.e generated by the oboparaer right now? |
|
So you think this would be correct? https://github.com/information-artifact-ontology/ontology-metadata/pull/158/files |
It's not "me" thinking; it's just what historically it has been defined. |
@cthoyt commented in geneontology/go-ontology#158 that he did not like the change. @cthoyt the file you shared cannot be taken as the authoritative source. We have to take the OWL API as the authoritative source, as this is what everyone is using to create OBO files:
translates to:
It will cause an uproar if we change that to |
@matentzn i don’t have an opinion either way, but I did not realize that the obo file is not authoritative. Since that’s the case, why not just update the obo file to be correct? |
I never considered this file to be authoritative tbh.. @kltm may know more of the history |
I better understand what's going on here. To reduce future confusion, can we create an authoritative OBO in OWL file (obo flat file format, OWL format) that can be considered authoritative? We need something like this in order to ensure people who are working with tools other than the OWL API can use it |
What exactly should that file contain? Is it basically like OMO, only covering all aspects of the OBO spec? |
I think I am having a big misunderstanding. There is a semantic space called How do I, as a human who doesn't want to read Java nor understand what the OWL API does under the hood, see what the list of all the local unique identifiers in this semantic space? The way I was doing this before was by looking at https://github.com/geneontology/go-ontology/raw/master/contrib/oboInOwl.obo. From what I understand from this conversation, there are inconsistencies between this file and what other people consider to be the "real" version of this semantic space, so I need a better solution than looking at this file, and there should probably be some kind of communication added inside this file about what it is, why it was made, and why it shouldn't be widely used Further, it appears there are some inconsistencies with https://raw.githubusercontent.com/geneontology/go-ontology/master/contrib/oboInOwl.owl and https://github.com/geneontology/go-ontology/raw/master/contrib/oboInOwl.obo. |
Not a big misunderstanding! Thats what I was asking. The metadata schema of oboInOwl is defined (mostly) here: https://owlcollab.github.io/oboformat/doc/obo-syntax.html Some stuff seems missing. Ideally there was something like what @cmungall created for obographs: https://github.com/INCATools/ontology-access-kit/blob/main/src/oaklib/datamodels/obograph.owl.ttl https://github.com/geneontology/go-ontology/raw/master/contrib/oboInOwl.obo is not all too bad, but I would recommend you raise this issue of a metadata schema in the obo-format channel. Maybe we can just update that one file. |
okay, I am convinced. Now I just have to wonder why the OBO file living in the same directory doesn't match this. I made an issue in geneontology/go-site#2157 so we can discuss that elsewhere. |
@matentzn I think we can close this |
Fixed by geneontology/go-ontology#158 |
This PR updates the OBO in OWL record (see current record at https://bioregistry.io/oboinowl) in the following ways: 1. Uses pseudo-PURLs for OBO and OWL download that correspond to the URIs 2. Add @kltm as the contact person. There's still some ambiguity as to how this file is maintained, but since the URIs point to the GO repo, I think this is probably a good call for now 3. Adds a loose pattern 4. Adds additional examples @matentzn @kltm I would love to have one of you contribute a more detailed description See related recent discussions: 1. geneontology/go-site#2157 2. information-artifact-ontology/ontology-metadata#157
OBO format convert into OWL:
One of the queries in ROBOT Report checks for "Missing Synonym Type Declaration" using the
oboInOwl:SynonymTypeProperty
For example, the abbreviation annotation in OLS.
The text was updated successfully, but these errors were encountered: