fix(geo): check catalog watcher befor destroy #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aziz-access
added
the
bug
alecarn
requested changes
Jan 29, 2024
Comment on lines
+103
to
+105
| if (this.watcher) { | ||
| this.watcher.destroy(); | ||
| } |
There was a problem hiding this comment.
En regardant l'assignation du watcher dans le OnInit, je ne vois pas pourquoi le watcher pourrait être à undefined car il est synchrone. Ce n'est pas clair dans la documentation d'Angular si le OnDestroy peut court-circuter le OnInit.
Mais en regardant les breadcrumbs de Sentry, on voit qu'une autre erreur arrive avant celle-ci #1599. J'ai l'impression que cette dernière est la cause de l'erreur. Qu'est-ce que t'en pense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: