New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type annotations #68

Open

5 tasks

atreyasha opened this issue Mar 14, 2023 · 0 comments

Member

atreyasha commented Mar 14, 2023 •

edited

Loading

Currently our type annotations are patchy and sometimes inconsistent. To address this, we should:

Fix type annotations everywhere in code such that mypy checks pass
Add mypy checks to GitHub build workflow
Consider using strict flag for more stringent checks
Consider relaxing mypy version constraint
Relax mypy import ignores as much as possible i.e. ignore as little as possible in pyproject.toml -> this implies installing some custom stubs such as types-tqdm and pandas-stubs

The text was updated successfully, but these errors were encountered:

atreyasha changed the title ~~Add type annotations and mypy CI~~ Type annotations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment