Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof-of-concept multi-thumb slider #1634

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdelight
Copy link

@jdelight jdelight commented Mar 17, 2022

What I did

  • implemented a very simple proof of concept multi-thumb slider
  • uses two input ranges layered on top of each other with some dynamic styles to indicate selected range
  • uses LionFieldset to present multiple inputs as a single control
  • requires a custom LionInputRange component to remove value/unit text or an attribute
    on the LionInputRange class to hide it
  • uses a similar technique to the one suggested here: https://css-tricks.com/multi-thumb-sliders-particular-two-thumb-case/

image

- uses two input ranges layered on top of each other with some dynamic styles to indicate selected range
- uses LionFieldset to present multiple inputs as a single control
- requires a custom LionInputRange component to remove value/unit text or an attribute
on the LionInputRange class to hide it
- uses a similar technique to the one suggested here: https://css-tricks.com/multi-thumb-sliders-particular-two-thumb-case/
@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2022

⚠️ No Changeset found

Latest commit: d7f898d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented May 23, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


James Da Costa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gerjanvangeest gerjanvangeest added enhancement New feature or request help wanted Extra attention is needed labels Oct 4, 2023
@gerjanvangeest
Copy link
Member

This PR still needs some attention, maybe we can bring it back to live and finalise it soon!
Anybody lending a hand, feel free 💪!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants