Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(types): create global type declarations for Lit #1878

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(types): create global type declarations for Lit #1878

wants to merge 1 commit into from

Conversation

tkgroot
Copy link
Contributor

@tkgroot tkgroot commented Jan 10, 2023

What I did

remove jsdoc @typedef lit references and replace them with global type declaration.

  • create prelude file with global type declarations
  • remove import('lit') from files
  • add lit types to global types
  • remove typedef for TemplateResult, RenderOptions, CSSResult CSSResultArray, CSSResultGroup, ReactiveController and ReactiveControllerHost
  • simplify type declarations/definitions

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2df6fcc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tkgroot
chore(types): create global type declarations
2df6fcc 
remove jsdoc @typedef lit references and replace them with global type declarations.
- create prelude file with global type declarations
- remove import('lit') from files
- add lit types to global types
- remove typedef for TemplateResult, RenderOptions, CSSResult
  CSSResultArray, CSSResultGroup, ReactiveController and ReactiveControllerHost
- simplify type delcarations/definitions

Signed-off-by: Tobias Kuppens Groot <[email protected]>
@tkgroot tkgroot force-pushed the chore/global-types branch from 281018e to 2df6fcc Compare January 10, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlouisse tlouisse Awaiting requested review from tlouisse tlouisse is a code owner

@daKmoR daKmoR Awaiting requested review from daKmoR

@gerjanvangeest gerjanvangeest Awaiting requested review from gerjanvangeest gerjanvangeest is a code owner

@erikkroes erikkroes Awaiting requested review from erikkroes

@ruphin ruphin Awaiting requested review from ruphin

@narzac narzac Awaiting requested review from narzac narzac is a code owner

@Knorgias Knorgias Awaiting requested review from Knorgias Knorgias is a code owner

@whenlit whenlit Awaiting requested review from whenlit

@DannyMoerkerke DannyMoerkerke Awaiting requested review from DannyMoerkerke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tkgroot