Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to lit3 and other dependencies #2159

Closed
wants to merge 2 commits into from
Closed

Conversation

gerjanvangeest
Copy link
Member

BREAKING CHANGE: update to latest major versions of lit, autosize, awesome-phonenumber & ibantools

What I did

BREAKING CHANGE: update to latest major versions of lit, autosize, awesome-phonenumber & ibantools
Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: ed59313

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -4,6 +4,7 @@ on:
push:
branches:
- master
Copy link
Member

@tlouisse tlouisse Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we can do just lit3 here (no master).
Once that becomes master, we remove lit3 branch and create a lit2 branch might we need it in the future (I suspect the need for it is way less then for our lit1 branch)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And once we create the lit2 branch, we should do this as well with a lit2 tag: 8702381

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's also better to call the branch lit3-alpha instead of lit3 (for clarity)

@@ -1,6 +1,6 @@
{
"name": "@lion/ui",
"version": "0.5.2",
"version": "0.5.2-alpha.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 0.6.0-alpha.

Also, we need to do this to prevent npm from referring to it as latest: 8702381

(but then with lit3 as tag).

@@ -4,6 +4,7 @@ on:
push:
branches:
- master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And once we create the lit2 branch, we should do this as well with a lit2 tag: 8702381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants