chore: align how IBAN validators messages work with other validators #2239
+230
−232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
getMessage()
class method by calling separate functions, IBAN validators overridegetMessage()
instance method which loads its own translation messagesloadDefaultFeedbackMessages()
while many other validators show the fallback messages like:loadDefaultFeedbackMessages()
orloadInputIBANMessagesNoSideEffects()
which is a BREAKING CHANGEloadDefaultFeedbackMessages()
to input-email documentWhy
While checking an old issue about IBAN error message (#1783), I found we can override the error message by doing:
but this requires the consumer of the component to know the implementation details that
IsIBAN
is the default validator oflion-input-iban
.If consumers see the message like Please configure an error message for "IsIBAN" by overriding "static async getMessage()", it is easier to figure out what needs to be done.
Also this behavior is more consistent with how other validators work and its document: https://lion-web.netlify.app/components/input-iban/use-cases/#country-restrictions
Discussion