Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] feat: Carousel component #2249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[POC] feat: Carousel component #2249

wants to merge 1 commit into from

Conversation

wessamzaghloul
Copy link
Contributor

@wessamzaghloul wessamzaghloul commented Apr 9, 2024 •
edited
Loading

What I did

  1. Added a POC for LionCarousel component with autoplay and manual navigation.
  2. Carousel accessibility and keyboard navigation.
  3. Followed basic carousel accessibility recommendations as in this example.
image

Next steps

  1. Move options to mixins.
  2. Probably replace LionPagination with LionTabs for better accessibility as in the recommendation here for tabbed carousel.
  3. Tryout the slide with animation using the _slideAnimation function.
  4. Add more tests.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7407d27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlouisse tlouisse Awaiting requested review from tlouisse tlouisse is a code owner

@gerjanvangeest gerjanvangeest Awaiting requested review from gerjanvangeest gerjanvangeest is a code owner

@narzac narzac Awaiting requested review from narzac narzac is a code owner

@Knorgias Knorgias Awaiting requested review from Knorgias Knorgias is a code owner

@okadurin okadurin Awaiting requested review from okadurin okadurin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wessamzaghloul