fix(input-stepper): move role=spinbutton to input node #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ced0dfa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gerjanvangeest
force-pushed
the
fix/input-stepper-a11y-refactor
branch
from
398e5e7 to
4c32259
Compare
gerjanvangeest
requested review from
tlouisse,
narzac,
Knorgias,
okadurin and
ryubro
as code owners
gerjanvangeest
force-pushed
the
fix/input-stepper-a11y-refactor
branch
from
4c32259 to
a0c0cd8
Compare
tlouisse
reviewed
Dec 11, 2024
tlouisse
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
role="spinbutton"to the inputNode.Before:
input-stepper_before.mp4
After:
input-stepper_after.mp4