Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some pages do get wrong vertical height of archived page #1

Open
Gozala opened this issue Mar 10, 2020 · 3 comments
Open

Some pages do get wrong vertical height of archived page #1

Gozala opened this issue Mar 10, 2020 · 3 comments

Comments

@Gozala
Copy link

Gozala commented Mar 10, 2020

It looks like https://notes.andymatuschak.org/About_these_notes gets a wrong height as seen in this excerpt:

https://ipfs.io/ipfs/QmQnW4pKAN2tSLHgCGojHkeT72N97JFx8b9zQsmJ34qBSi/

Presumably that is because we capture height onload event at which point it seems to be 44px, I'm guessing height is changed a bit later although I don't exactly know why, given no presence of JS I don't see how it comes to be.

@Gozala
Copy link
Author

Gozala commented Mar 10, 2020

I think it is worth considering alternative where excerpt is inserted into freeze dried page instead. In my tests doing something along the following lines:

body {
  transform: translateY(100vh)
}

#excerpt {
  position: absolute;
  top: 0;
  left: 0;
  width: 100%;
  transform: translateY(-100vh);
}

Works relatively well. However issues arise if #excerpt overflows (it definitely will on mobile). Finding a way to do it without absolute positioning would be ideal.

@Gozala
Copy link
Author

Gozala commented Mar 11, 2020

@Gozala
Copy link
Author

Gozala commented Mar 12, 2020

I have settled on temporary solution that sets min-height: 100vh on iframe which addresses issue mostly. But all this is still an issue on mobile. As both captured height on desktop and min-height are ways to short.

Keeping this open to try and find a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant