Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set JAVA_OPTS #18

Closed
kostyrev opened this issue Nov 30, 2016 · 5 comments
Closed

set JAVA_OPTS #18

kostyrev opened this issue Nov 30, 2016 · 5 comments

Comments

@kostyrev
Copy link
Collaborator

kostyrev commented Nov 30, 2016

Hello! I need to pass a bunch of JAVA_OPTS
e.g.

JAVA_OPTS="$JAVA_OPTS -XX:+UseThreadPriorities "
JAVA_OPTS="$JAVA_OPTS -Djboss.remoting.pooled-buffers=false"

and such to wildfly.
Usually my team injects those to {{ wildfly_dir }}/bin/standalone.conf
But this is not possible using this role 'cause it does not manage template for that file.
What be a good solution to this problem?
I'm thinking about adding a task to solve this but what would be a best option?
I could add template for {{ wildfly_dir }} /bin/standalone.conf or a blockinfile task
What do you think?

@inkatze
Copy link
Owner

inkatze commented Nov 30, 2016

If you want to create a task to support a standalone.conf template that would be ok. Actually I'm ok with most additions as long as they're retro-compatible (ideally).

I also notice you added some more PRs; I have some free time today so I think I can review some of them, please be patient and thank you very much for your additions :)

@kostyrev
Copy link
Collaborator Author

kostyrev commented Nov 30, 2016

Yeah.. I've added a lots of stuff.
But they all are backward-compatible and all the logic runs through feature toggles.
I also added molecule for CI but for some reason molecule itself is broken on Travis. It runs OK on my machine. I'll investigate it in a while.
You can install molecule like this and test it for yourself. It's very convenient instrument.

@kostyrev
Copy link
Collaborator Author

But still.
How do you pass JAVA_OPTS to your wildfly?

@inkatze
Copy link
Owner

inkatze commented Nov 30, 2016

I'm not sure if this is what you are referring to since I'm not very Java savvy but I think I'd use wildfly.conf.j2 to add JAVA_OPTS, and things like jboss.remoting.pooled-buffers=false in wildfly.properties.j2. But as #16 describes, the systemd script doesn't support those files and those files don't support user supplied options at the moment.

@kostyrev
Copy link
Collaborator Author

I don't care for CentOS7 and systemd so the hell with it)
I found a workaround using task with blockinfile outside of the role and that will do for my use-case.
So I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants