Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trims do not work in pyembroidery when written from Ink/Stitch #75

Open
MatsIBengtsson opened this issue Aug 8, 2019 · 3 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@MatsIBengtsson
Copy link
Collaborator

I have a Husqvarna viking Topaz 50 machine, which does trims. When doing designs in inkstitch exported through pyembroidery, my trims does not work as I expect (they do not trim at all).

Free version of Premier (Husqvarna/Pfaff embroidery software), tells me there are no trims in the generated vp3 file. The free version of truesize e4, tells me there are only two trims in the vp3 file (a file with two colors).

Saving to formats like dst or pes, generates the trims as expected.

The issue is also described in Ink/Stitch ( #inkstitch/inkstitch#495) and in EmbroidePy/pyembroidery (EmbroidePy/pyembroidery#68). Enclosing a zip file containing a number of files to give details outline cat face p0.0-006.zip

The files are described below, and contain information on the difference when using Premier/trueview or going through pyembroidery.

  • The inkscape svg file which contains the design, as done with inkscape and Ink/Stitch (done more or less from scratch, however, the paths are imported from a drawing done in illustrator). That does not seem to have ill effects.
  • The vp3 file as created by Ink/Stitch (outline cat face p0.0-006.vp3). It does not manage to convince my embroidery machine to do any trimming, neither does it make Wilcom truesize believe it should.
  • A screen dump of Wilcom truesize interpretation of the vp3 file created by Ink/Stitch (Wilcom truesize interpretation of InkStitch vp3 file.PNG). It seem to accurately describe all trims not occuring (color changes are trimmed, but they are always trimmed independent on what commands the vp3 file contains, so likely not due to a trim command in Ink/Stitch vp3 file)
  • The dst file created by Ink/Stitch. It convinces Wilcom truesize that there are trim commands defined in the file, just as claimed by Ink/Stitch.
  • The vp3 file created by taking the Ink/Stitch dst file into Wilcom truesize, and export as a vp3 file (outline cat face p0.0-006 wilcom from dst.VP3). That vp3 file, according to Wilcom, does contain a number of the wanted trim commands (not all of the ones defined from the beginning in the dst file, but many). It convinces my embroidery machine to trim the thread in many of the wanted places. Side note: Taking the Ink/Stitch vp3 file and saving from Wilcom truesize as vp3 does not produce any visible trims. It does add one extra line, likely a start thread, so something is missing in the vp3 file as saved by Ink/Stitch.
  • A wilcom truesize screen dump of its interpretation of the vp3 file Wilcom truesize created using the Ink/Stich dst file (Wilcom truesize interpretation of InkStitch dst file saved as vp3 with lines.png). With lines showing the differences between Wilcom truesize view, and final results on the embroidery machine:
  • Wilcom was almost right. There is an extra start thread it expects, which does not show up (encircled in black in the screen dump). Wilcom expects same extra thread when just saving the InkStitch vp3 file using Wilcom truesize. Likely something I have extra in my svg file.
    Three threads which are not trimmed, although Wilcom expects them to be (shown as three black lines on the screen dump). One up in top left corner of the eye, and two connecting to and from the nose.
@B-Lemke
Copy link

B-Lemke commented Sep 21, 2021

Just wanted to comment that I am also experiencing these issues with a Topaz 50 and exporting to .vp3 format

@lauris-nl
Copy link

On a:
Pfaff Creative 1.5
the *.vp3 files from inkstitch only trims on color chance. Not at placed trim "Ink/Stitch Command: Trim thread after sewing this object"

@V2600
Copy link

V2600 commented Feb 20, 2022

I've been researching here in github about the VP3 trim issue.
Currently it still does not seem to be working properly on VP3 or PES exports from Inkstitch v2.1.2 (windows) using my Pfaff Creative Vision 5.0

I did some personal testing
I tested with a file from a free plush pattern designed by professional plush artist known as CholyKnight.
The files and licensing can be found at the following:

Download link for the embroidery files
https://cholyknight.com/wp-content/uploads/2019/07/t-rex-plush-embroidery-files.zip

Original post for plush
https://cholyknight.com/2019/07/05/t-rex-plush/

Licensing for the original files
// ©2019 Choly Knight // Items sewn using this design may be sold. Credit to “Choly Knight” or “Sew Desu Ne?” is appreciated.
You may not reproduce, share, freely distribute, or sell this design as your own in digital or printed form.

Steps to reproduce:
File path: Classic Eye > 4x4 Classic Eye > 4x4 Classic Eye Right > 4x4 Classic Eye Right.PES

-File > Open > PES file
-File > Save As > VP3 file

Please be aware that PES file was used due to import problem involving satin stitches on VP3 files

Neither the inkstitch exported VP3 or PES file retained trim information.
This was tested against CholyKnight's original 4x4 Classic Eye Right.VP3 and Classic Eye Right.PES file which do trim.

More than happy to assist testing with my machine but I'm by no means a developer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants