Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading documentation for migration from v2 to v3 #979

Closed
nicoabie opened this issue Oct 31, 2024 · 1 comment · Fixed by #1046
Closed

Misleading documentation for migration from v2 to v3 #979

nicoabie opened this issue Oct 31, 2024 · 1 comment · Fixed by #1046
Assignees

Comments

@nicoabie
Copy link

https://www.inngest.com/docs/sdk/migration#clients-and-functions-require-ids

"We recommend changing the property name and wrapping the value in slugify() to ensure you don't redeploy any functions."

We changed our inngest client name: "Rec" to id: slugify("Rec") and that caused our app to be archived and a new app to appear.

All functions started to fail. We had to unarchive the original app, create a new PR changing from id: slugify("Rec") to id: "Rec" and manually copy all events that failed and replay them one by one as there is no way to select to which app run an event...

Very unfortunate...

Slugify is safe for functions but not for app id!!!

@charlypoly
Copy link
Contributor

Hi @nicoabie,

I am sorry for the ambiguity that led to your application being archived.

I've created a PR adding a warning notice specifying that the use of slugify() only applies to function IDs and not App IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants