bug(YouTube/Toolbar components) : Hide trending searches doesn't work
#1993
Comments
|
All other search terms are not hidden. |
If I open another issue like |
|
Just now, I noticed this. BTW, my watch history & search history is disabled, and both have zero items in them. Same issue on ReVanced's repository : ReVanced/revanced-patches#873 When When So, it is requested to make
|
|
It makes sense. |
inotia00
changed the title
Hide Trending Searches doesn't work if watch history has zero videos.Hide trending searches doesn't work
|
Thanks! Any chance of making it work in accordance to the new server-side changes? |
|
When I checked the bytecode, I couldn't make it support the new server-side changes right now.
|
In the past, I have filtered this new "suggestion searches" via "yt_outline_new_search_black_24" drawable inside resources. However, it have some layout problem so I decided to reject this changes |
|
Removing setting is not a big deal until server-side changes are supported. |
|
Additational, trending search setting hides the search suggestion with the Fire icon, not other search suggestion type so I think you should close this issues without removing patch |
The patch is still worked, it did its jobs (hide searches with |
nah.. refer it
|
Ah got it |
|
reflected in revanced-patches-4.8.3 |
This means that there is a possibility of this feature returning in the future (if inotia00, anddea, YT-Advanced, ReVanced Team or other devs figures out how to make it work). I think, for this reason alone, this issue should be kept open. Keeping the issue open gives the users hope that this Tier-1 feature may return someday. |
|
So the problem happens when the searchbar is empty and the suggested results (with zoom lens icon) are visible. In this case it should be possible to add a further check to hide all the results dinamically, once the searchbar is empty. @inotia00 the removed patch allow to hide everything together in 3 steps (1 for every icon), just the empty searchbar check need to be implemented. |
|
These They do show when you have 0 videos in your watch history. So, is there any way to "spoof" the search page making it think that the user has some videos in their watch history? That could make hiding it possible, even if user has 0 videos in watch history in reality. |
Unfortunately I can't reproduce this issue on my side. I got always 0 trending results, also with an empty history list. In the opposite case, I would have already tried to solve the problem. |
|
Anyway...try to patch the latest RvX version with the removed patch, and check if the bug has been solved. A similar problem happened to me 4 months ago, and solved itself after some weeks. |
|
Hmm. BTW, people who doesn't add account to RVX app also don't get Any way to spoof that? |
Using these patches + 0 videos in watch history + watch history paused.
Getting this:
|
If there is a way, I don't actually know how to achieve it. But it's pointless, due to others (and more easier) way to fix it. If the bug still exists on last version of RvX, a check on the searchbar digited text could be done. |
You are using a version without patch (has been removed by inotia 2 months ago, waiting for the A/B test to finish). You should repatch the last RvX version, but with the removed patch. |
|
@YT-Advanced Can you port this mod to RvX? I'm allergic to kotlin. 👍 |
Uhm rn it seem like A/B Testing, so I cannot test this stuff in my side |
NOTE : Check all comments for new information.
Type
Cosmetic
Tools used
Revancify
Application
YT v19.16.39
Patches v4.8.0-dev.4
Integrations v1.9.0-dev.3
Bug description
Hide Trending Searches doesn't work if watch history has zero videos.
To make it work, I enabled my watch history, then I watched one video, then disabled watch history. After doing this, Hide Trending Searches immediately starts working perfectly. It has been like this for months.
But this comes with a cost. With 1 video in your watch history, Home Feed suggestions come back for you.
So, it is requested to make Hide Trending Searches work even if user's watch history has zero videos.
Error logs
Solution
The functionality of Hide Trending Searches shouldn't depend on the number of videos in user's watch history.
Additional context
No additional context.
Device Environment
Realme 7 Pro running on Android 12 (skin name is Realme UI 3.0).
Acknowledgements
The text was updated successfully, but these errors were encountered: