Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jcli lib refactor #3172

Open
2 of 5 tasks
danielSanchezQ opened this issue Mar 24, 2021 · 0 comments
Open
2 of 5 tasks

Jcli lib refactor #3172

danielSanchezQ opened this issue Mar 24, 2021 · 0 comments
Assignees
@filip-dulic-bloxico
Labels
A-jcli Area: Command Line Interface and tooling

Comments

@danielSanchezQ
Copy link
Contributor

danielSanchezQ commented Mar 24, 2021 •
edited by filip-dulic-bloxico
Loading

As noted when making jcli as an available library: #3163

Things to do:

  • Extract jcli-lib into its own crate
  • Scope dependencies into features (expose just what we need depending on the usage type. For example StructOpt would be just needed for cli tools).
    • structopt feature
    • TBD
  • Refactor API and expose non exposed functionality
@danielSanchezQ danielSanchezQ added the A-jcli Area: Command Line Interface and tooling label Mar 24, 2021
filip-dulic-bloxico added a commit that referenced this issue Apr 13, 2021
@filip-dulic-bloxico
Add new jcli-lib crate to workspace
2f5f5a9 
This is the beginning step for refactoring the jcli-lib crate from the
jcli binary crate. This is the starting commit for #3172
filip-dulic-bloxico added a commit that referenced this issue Apr 13, 2021
@filip-dulic-bloxico
Add new jcli-lib crate to workspace
a28223f 
This is the beginning step for refactoring the jcli-lib crate from the
jcli binary crate. This is the starting commit for #3172
@filip-dulic-bloxico filip-dulic-bloxico linked a pull request Apr 13, 2021 that will close this issue
Refactor into jcli-lib crate #3216
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filip-dulic-bloxico filip-dulic-bloxico

Labels
A-jcli Area: Command Line Interface and tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor into jcli-lib crate input-output-hk/jormungandr
2 participants
@danielSanchezQ @filip-dulic-bloxico