Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow github actions #550

Closed
4 tasks done
Alenar opened this issue Oct 12, 2022 · 1 comment
Closed
4 tasks done

Update workflow github actions #550

Alenar opened this issue Oct 12, 2022 · 1 comment
Assignees
Labels
D-easy Difficulty: easy dependencies Updates a dependency file P-low Priority: low

Comments

@Alenar
Copy link
Collaborator

Alenar commented Oct 12, 2022

Context

Since Node 12 have reached end of life in April 2022, github actions are switching to node16 as the new default.
To push project to update github started to output a warning in actions logs for each outdated actions:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: [...]

You can see them popping in the last merge on main: https://github.com/input-output-hk/mithril/actions/runs/3235984569

Problem

Not all of the third party actions we used has been updated as of the 12th October 2022 (ie: all rust actions are still outdated).

We will have to monitor for their update and ensure that those updates don't come with a breaking change or else do the required adaptations.

Actions to update

  • All rust dedicated actions from the action-rs org. ⚠ Those actions have seen no updates since two years and the only maintainers show no sign of activity, we should consider to replace them using only command lines + SARIF upload for clippy check.
  • Legion2/swagger-ui-action@v1: already updated to node-16 but we have yet to see a release with this change, hopefully it will be a minor version if so we have nothing to do but wait It have been updated.
  • marvinpinto/action-automatic-releases@latest: ⚠ Like the action-rs org the maintainer show no sign of activity. => Replaced with softprops/action-gh-release@v2.
  • tubone24/[email protected]: This action repository show no sign of activity expect automatic dependencies updates and the last commit by the maintainer is from December 2021 but since he's still active on other repository the update may come sooner or later.
@Alenar Alenar added D-easy Difficulty: easy dependencies Updates a dependency file P-low Priority: low task labels Oct 12, 2022
@Alenar Alenar self-assigned this Oct 12, 2022
@Alenar Alenar mentioned this issue Oct 12, 2022
10 tasks
@Alenar Alenar mentioned this issue Dec 5, 2022
5 tasks
@Alenar
Copy link
Collaborator Author

Alenar commented Oct 15, 2024

With #2007, all actions are now using github supported node versions 🚀 .

@Alenar Alenar closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-easy Difficulty: easy dependencies Updates a dependency file P-low Priority: low
Projects
None yet
Development

No branches or pull requests

2 participants