-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance logs construction and usage in aggregator #2002
Conversation
Use full path instead of needing a use gated by an `cfg(test)` that add noises with the other imports.
To create child logger when there's no component to hold them (such as the http server in aggregator).
* Tagged with the component name. * Existing logs are still using `slog_scope` but this prepare its removal.
… http server To tag the logs with a source so they may be easily filtered.
… services & tools To tag the logs with a source so they may be easily filtered.
a9f8587
to
24be951
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work
Just a doubt about a function name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
…ertificate_repository`
It's still a `dev-dependencies` as it is useful for integration tests.
Instead of the default `slog-rs`.
* mithril-aggregator from `0.5.80` to `0.5.81` * mithril-common from `0.4.67` to `0.4.68`
24be951
to
01bf63f
Compare
Content
This PR refactor the log usage in
mithril-aggregator
:slog_scope
to enforce the usage of a name tagged child logger (only kept in the integration tests).slog-rs
tomithril-signer
.Pre-submit checklist
Comments
As this PR is already quite big, a second PR will come that will pass over all logs in the aggregator to move away from the log message huge structure into properties, to remove prefixes in message as now all logs are tagged with their source, and to enforce a common style & structure.
Issue(s)
Relates to #1981