-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme for developers #476
Comments
clarkliming
added a commit
that referenced
this issue
Apr 26, 2023
export checks and use `::` in pre functions part of #476 --------- Signed-off-by: Liming <[email protected]> Co-authored-by: b_falquet <[email protected]>
This was referenced May 5, 2023
clarkliming
added a commit
that referenced
this issue
May 17, 2023
following #476, I tried to make the templates a bit clearer. something added 1. for aet01_aesi and aet01 template, remove the check functions in pre. all these derivations are executed without check! as users are responsible for these derivations and they are clear. more checks added in `main` functions 1. check the arm variable are identical in levels (in adsl and adae) 2. check variables to analyze exists (especially those new derived) 3. remove `deco`. titles/footnotes should be handled in citril using lopo 1. remove aet01_2. this can be handled through arguments of aet01 1. for aet02 template, variants are removed. can be achieved through argument `row_split_var` 2. add many utility functions (currently put in aet02.R but should go into utility.R) 3. valid_row_path. this checks if a row_path is valid for a table 4. valid_sort_at_path. this conduct the sort based on `row_path` if it is valid. (sort_at_path gives error on incorrect row_path provided, and aet02_1 previously will run into issues if prune_0 = FALSE on empty data) 5. get_sort_path. this function will create "*" between variables, e.g, `get_sort_path(c("A","B"))` will give "A" "*" "B", this is required by `sort_at_path` 6. tlg_sort_by_var. this functions will sort using "A" and "B", instead of "A" "*" "B". Also will check if the table contains the path. if does not contain the path, the sorting will be ignored. I think some of the funcitonality should go into tern/rtables. But for now let's use them. Please review this update in general and I will finalize this PR if no objections. Then everyone can collaborate to harmonize all templates. @Teninq @BFalquet @duanx9 @crazycatandy @barnett11 --------- Signed-off-by: b_falquet <[email protected]> Co-authored-by: benoit <[email protected]> Co-authored-by: b_falquet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
to make chevron executable in scripts with arguments, we need to make sure
logical
,character
,numeric
, or (named nested) list of themmatch.arg
can be used now.::
to explicitly call functions, unless it is already called through "library" in scriptdunlin
(currently in chevron we create standard rules).pre
function should have very straightforward derivations for users to understand.reformat(xxx, xxx)
, instead of usingreformat.list
methodanl01fl = "Y"
can be added herePARAMCD
, depends on if we would like to use it as a suffix.main
function do use the variable derived frompre
3. unit tests should use
cat(export_as_txt(...))
to make sure the output is good5. adsl, under no circumstances, can be empty (there will not be outputs filter adsl to empty!)
6. other datasets, could be empty
2. it created table possibly not paginatable
Release related:
The text was updated successfully, but these errors were encountered: