Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teal with bioconductor 3.14 #345

Closed
nikolas-burkoff opened this issue Oct 28, 2021 · 3 comments · Fixed by #365
Closed

teal with bioconductor 3.14 #345

nikolas-burkoff opened this issue Oct 28, 2021 · 3 comments · Fixed by #365
Assignees
Labels

Comments

@nikolas-burkoff
Copy link
Contributor

From https://github.com/insightsengineering/teal/issues/325 there is a problem running 4 teal tests.

@gogonzo can reproduce and will figure out which package the problem is coming from etc.

@gogonzo
Copy link
Contributor

gogonzo commented Oct 29, 2021

Issue submitted in the package repo. I think it's a problem of subsetByColData which does not handle NA like all subset functions.
waldronlab/MultiAssayExperiment#303

@gogonzo gogonzo added the SP2 label Oct 29, 2021
@pawelru pawelru added the devops label Nov 3, 2021
@gogonzo
Copy link
Contributor

gogonzo commented Nov 5, 2021

Discussion continuous in MAE repo. Also found an issue in S4Vectors which is not related with current one.

@gogonzo
Copy link
Contributor

gogonzo commented Nov 8, 2021

Ok, I'm done with this MAE author. Discussion does not make sense as he ignores strong reasons and tries to defend himself in the eyes of the user imputing general misconception. I suggest now to fix the teal as his proposition to add na.rm to subsetByColData is his "new idea" and there is still no issue created for this.

I think these should be possible instead of subsetByColData(<dataname>, <condition> & <condition>):

MAE_FILTERED@colData <- subset(MAE_FILTERED@colData, <condition> & <condition>)
# or
MAE_FILTERED <- subsetByColData(MAE_FILTERED, <condition & !is.na(varname1)> & <condition & !is.na(varname2)>)
# or 
MAE_FILTERED <- subsetByColData(MAE_FILTERED, which(<condition> & <condition>))

edit:
Before we try to work-around let's wait for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants