Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

Use a standard state management library [ngrx/store] and strategy #273

Open
harunurhan opened this issue Dec 14, 2017 · 0 comments
Open

Comments

@harunurhan
Copy link
Collaborator

Overtime even this app is getting big and having more and more components. And naturally there are some state that are required by different components that are no where to close each other in the app hierarchy. Thus we'll have to use multiple @Input and @Output combinations to share a single state, which is ugly and not scalable at all.

Another thing we do sometimes (not always so no consistency here) to solve this problem, use different services with both observable and non reactive regular variables (no consistency again)

Which is why I think we should start using https://github.com/ngrx/platform which is like rxjs powered react for angular.

And if a state goes out of an component scope, it has to be part of more global scope. Although we can make some exceptions for 1 level nested @output and @input passing if it makes too much sense.

This is an issue not only concerning record-editor but also https://github.com/inveniosoftware-contrib/ng2-json-editor (even though some cases not fit for ngrx, so needs to be evaluated separately) and https://github.com/inspirehep/ng2-multi-record-editor (@Glignos)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant