Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Observation from state in public API #195

Open
EdanToledo opened this issue Aug 11, 2023 · 3 comments
Open

[Enhancement] Observation from state in public API #195

EdanToledo opened this issue Aug 11, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@EdanToledo
Copy link

Is your feature request related to a problem? Please describe

It would be nice to have a standard and publicly exposed function to get an observation from the current environment state. I would imagine almost all environments in jumanji have this function internally but its not exposed and might differ depending on the selected environment. I'm not sure how relevant this would be for various people but i know it could help and libraries such as Gymnax has done it.

Describe the solution you'd like

Publicly exposed and standard function call to get the current observation from an environment state.

Hopefully I haven't missed this functionality already...

@EdanToledo EdanToledo added the enhancement New feature or request label Aug 11, 2023
@carlosgmartin
Copy link

Are you thinking of something along the lines of State.observation or Environment.observe(state)? I personally lean toward the latter, since it keeps State objects free of any constraints. (Related: #211.)

@EdanToledo
Copy link
Author

The latter is preferred definitely. I just think it would be useful for quite a few use cases.

@sash-a sash-a added the help wanted Extra attention is needed label Oct 25, 2024
@sash-a
Copy link
Collaborator

sash-a commented Oct 25, 2024

Thanks Edan I do like this suggestion, would be a lot to implement and I likely won't have the time for a while so if anyone wants to pick it up I'll happily review the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants