Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook RBAC template bug #4

Open
r00tvvm opened this issue Sep 30, 2021 · 0 comments
Open

Webhook RBAC template bug #4

r00tvvm opened this issue Sep 30, 2021 · 0 comments

Comments

@r00tvvm
Copy link

r00tvvm commented Sep 30, 2021 •
edited
Loading

Looks like these are bugs in RBAC template.

  1. ServiceAccount name and namespace are same values
    https://github.com/instana/instana-autotrace-webhook/blob/main/incubator/instana-autotrace-webhook/templates/mutating-webhook-rbac.yaml#L6-L7
    Fix: name: {{ .Release.Name }}

  2. Static defining of app.kubernetes.io/instance
    https://github.com/instana/instana-autotrace-webhook/blob/main/incubator/instana-autotrace-webhook/templates/deployment.yml#L18
    is causing conflict in case webhook deployed under other release name
    https://github.com/instana/instana-autotrace-webhook/blob/main/incubator/instana-autotrace-webhook/templates/_helpers.tpl#L43
    Fix:

L18:
   selector:
    matchLabels:
      app.kubernetes.io/name: {{ include "instana-autotrace-webhook.name" . }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@r00tvvm