Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup menu goes under notch in iphone 12 #235

Open
itsramiel opened this issue Dec 13, 2021 · 3 comments
Open

Popup menu goes under notch in iphone 12 #235

itsramiel opened this issue Dec 13, 2021 · 3 comments

Comments

@itsramiel
Copy link

Whole app is wrapped inside MenuProvider, but popup menu is not respecting safeArea

WhatsApp Image 2021-12-13 at 7 22 13 PM

@sodik82
Copy link
Contributor

sodik82 commented Dec 13, 2021

hi... quick check in the code - it looks like popover does not "reflect" safearea (unlike default ContextMenu renderer). However data are available, so PR (or own renderer) shouldn't be that hard.

something like

export const fitPositionIntoSafeArea = (position, layouts) => {

@itsramiel
Copy link
Author

would you be able to push such change to Popover. I am really not that good.

@itsramiel
Copy link
Author

:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants