Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Demand unit to Consumers screen and include in Target explanation copy #615

Open
manumoreira opened this issue Mar 31, 2021 · 2 comments · Fixed by #623
Open

Add Demand unit to Consumers screen and include in Target explanation copy #615

manumoreira opened this issue Mar 31, 2021 · 2 comments · Fixed by #623
Assignees

Comments

@manumoreira
Copy link

manumoreira commented Mar 31, 2021

This is how it should look like
Screen Shot 2021-03-31 at 13 54 53
Currently, we are not doing any filter by age or gender (mainly because the datasets we are using do not have that information) so the Consumer unit is always total population, we should change its default value to total population

@ismaelbej ismaelbej self-assigned this Apr 6, 2021
@ismaelbej
Copy link
Contributor

ismaelbej commented Apr 7, 2021

@manumoreira Currently "Consumer unit" is used in two places "Scenario Info"

Screen Shot 2021-04-07 at 16 11 03

and "Provider Info"

Screen Shot 2021-04-07 at 16 11 19

Should we replace them with "Demand unit" instead?

@manumoreira
Copy link
Author

@ismaelbej exactly we should replace Consumer unit by Demand unit in these two places as well as in the review screen
Screen Shot 2021-04-08 at 15 14 33
.... BTW, why is per year there?... could you please delete that...

@ismaelbej ismaelbej linked a pull request Apr 9, 2021 that will close this issue
@ismaelbej ismaelbej removed a link to a pull request Apr 9, 2021
@ismaelbej ismaelbej linked a pull request Apr 9, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants