Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down major.minor versions in requirements.txt #1851

Closed
n1hility opened this issue Jul 24, 2024 · 4 comments
Closed

Lock down major.minor versions in requirements.txt #1851

n1hility opened this issue Jul 24, 2024 · 4 comments
Assignees
Labels
bug Something isn't working dependencies Relates to dependencies

Comments

@n1hility
Copy link
Member

In the run up to 0.18.0 we should lock down all of our deps to minor versions in our requirements file to prevent surprise updates coming in (e.g. like torch 2.4).

@n1hility n1hility added the bug Something isn't working label Jul 24, 2024
@n1hility n1hility added this to the 0.18.0a7 milestone Jul 24, 2024
@bjhargrave
Copy link
Contributor

See also #1425

@nathan-weinberg
Copy link
Member

cc @tiran @RobotSail @leseb since they were involved in the PR linked by @bjhargrave

@n1hility
Copy link
Member Author

I'm closing this in favor of using constraints per the proposal in #122

@n1hility n1hility closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2024
@ktam3 ktam3 removed this from the 0.18.0b1 milestone Jul 25, 2024
@nathan-weinberg
Copy link
Member

@n1hility think you wanted to link instructlab/dev-docs#122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Relates to dependencies
Projects
None yet
Development

No branches or pull requests

4 participants