Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e test takes over an hour #328

Open
RobotSail opened this issue Nov 11, 2024 · 6 comments
Open

e2e test takes over an hour #328

RobotSail opened this issue Nov 11, 2024 · 6 comments
Labels
CI/CD Affects CI/CD configuration enhancement New feature or request

Comments

@RobotSail
Copy link
Member

This needs to be way quicker. Realistically we should always be running off of a precomputed dataset.

@nathan-weinberg
Copy link
Member

Duplicate of instructlab/instructlab#2496

@ktam3
Copy link

ktam3 commented Nov 21, 2024

@RobotSail can we close this in favor of instructlab/instructlab#2496

@RobotSail
Copy link
Member Author

@ktam3 We should keep this one as it's specific to the training repo and may not reflect the needs of the CLI repo.

@nathan-weinberg
Copy link
Member

nathan-weinberg commented Nov 21, 2024

@RobotSail
Copy link
Member Author

@nathan-weinberg What I'm saying is that the github action files defining the e2e tests are physically located in this repo. Although the script we're running lives in the instructlab repo, we still define the tasks here separately from the upstream repo.

@RobotSail
Copy link
Member Author

We should keep this issue here as the needs of the training repo may be different from that of the instructlab repo & the SDG repo.

@nathan-weinberg nathan-weinberg added enhancement New feature or request CI/CD Affects CI/CD configuration labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Affects CI/CD configuration enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants