Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Access Denied" page #267

Open
toraponibm opened this issue Oct 14, 2024 · 5 comments
Open

Improve "Access Denied" page #267

toraponibm opened this issue Oct 14, 2024 · 5 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@toraponibm
Copy link

When the user logs in with their github account, after confirming the app access they are redirected back to the error page if they're not part of the org member.

The current page just contains the link back to the app top page as well as the github org https://github.com/instructlab . Since this is the likely flow which any first-time user goes into, we should provide some more information.

  • Put a concise instruction on how to request access.
  • Review the design and ideally show the view in a consistent look as other pages.
Screenshot 2024-10-14 at 9 33 50 AM
@vishnoianil vishnoianil added the bug Something isn't working label Oct 15, 2024
@vishnoianil vishnoianil added this to UI Oct 15, 2024
@vishnoianil vishnoianil moved this to Ready in UI Oct 15, 2024
@vishnoianil vishnoianil added the good first issue Good for newcomers label Oct 15, 2024
@vishnoianil vishnoianil added this to the release-1.1 milestone Oct 15, 2024
@vinhyan
Copy link
Collaborator

vinhyan commented Oct 17, 2024

Hi @vishnoianil & @toraponibm! I'd like to give this a try please if possible.

Thank you!

@vishnoianil vishnoianil assigned vinhyan and unassigned vinhyan Oct 18, 2024
@vishnoianil
Copy link
Member

Hi @vishnoianil & @toraponibm! I'd like to give this a try please if possible.

Thank you!

@vinhyan awesome. thanks for picking this up. We has some brainstorming around this in last community UI meeting.

Currently for user to access the UI, they need to join the "instructlab-public" organization. User can join this organization by invitation from the admins. Admins sends the invitation using an inviter app. This inviter app requires user's github email address and a password, and admin's are the one has access to the password.

In last community meeting it was decided that we would like to remove the requirement for the password or we share the password on this 404 page itself.

Once user authenticate and see 404 due to not part of the instructlab-public org, they should be displayed 404 page, with the details like "You need to be part of the InstructLab public org to be part of this organization. This page will redirect to the self invitation page. Please user the password "xxxxx" and the email address associated with your github account to send the invitation. Once you receive the invitation, and accept the invitation, it should allow you to access the ui.instructlab.ai."

Bit of a strech goal is, if we can show the password initially invisible (******) and provide a button that toggle to visible, that would be helpful to prevent spams from bots.

cc: @nerdalert what do you think?

@vinhyan
Copy link
Collaborator

vinhyan commented Oct 18, 2024

Hi @vishnoianil, thank you for the detailed explanation!

It seems we're still deciding between removing the password entirely or sharing it on the 404 page. Please let me know once a decision has been made, and I'll implement it accordingly.

For the UI on the 404 page, I'm considering using the same design as the githublogin.tsx page to keep everything cohesive. Let me know if that works, or any ideas/suggestions would be helpful:

githublogin

@vishnoianil
Copy link
Member

hey @vinhyan, @nerdalert and myself had a discussion around how we can make this invitation process more seamless. Based on PR #278 from @nerdalert, i cooked up the following PR #282 . This PR actually removes the need of error 404 page itself.

Please review #282 and provide your thoughts.

@vinhyan
Copy link
Collaborator

vinhyan commented Oct 18, 2024

Hi @vishnoianil! Thanks for the update - this flow is definitely more seamless compared to redirecting the user to the 404 page :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Ready
Development

No branches or pull requests

3 participants