Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Migrate from environment specific secrets to repo specific secrets #365

Open
Gregory-Pereira opened this issue Nov 20, 2024 · 1 comment
Assignees

Comments

@Gregory-Pereira
Copy link
Collaborator

Unless we are doing this (having secrets only available to the main and release-1.0 branches), I would like to move secrets to be available on all upstream branches. If we are concerned about security, we can limit those who create upstream branches with the following settings: Restrict who can push to matching branches, and Restrict pushes that create matching branches. Why would this be valuable? This means that If I am fixing something in CI, we can test it on an open PR without having to merge it to main. This is will be important as we group to help remove downtime. Here is a perfect example of where this might be useful for testing: #364

Happy to take this on if we agree with the idea @vishnoianil and @nerdalert

@vishnoianil
Copy link
Member

@Gregory-Pereira Sounds good to me, but we need to make sure "Restrict pushes that create matching branches" is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants