Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF cleanup: standardize on import statements #367

Open
nicolethoen opened this issue Nov 21, 2024 · 0 comments · May be fixed by #441
Open

PF cleanup: standardize on import statements #367

nicolethoen opened this issue Nov 21, 2024 · 0 comments · May be fixed by #441
Assignees
Labels
good first issue Good for newcomers tech debt UX Related to the user experience
Milestone

Comments

@nicolethoen
Copy link

There are a few places where PF components are being imported from different locations.

Most places, i've noticed components are imported from @patternfly/react-core/dist/dynamic...
Some places, components are import using a different pattern, like @patternfly/react-core like here.

Unless there's an architectural reason to do otherwise, I think it's likely easiest to import all PF components from @patternfly/react-core and let the build config determine resolve the import the way it's set up to.

If you need to use a deprecated component - you'd import them from @patternfly/react-core/deprecated
But PF does provide a non-deprecated solution for every deprecated component - feel free to reach out if those solutions are not working for findable for any reason.

@vishnoianil vishnoianil added UX Related to the user experience tech debt good first issue Good for newcomers labels Nov 21, 2024
@vishnoianil vishnoianil added this to UI Nov 21, 2024
@vishnoianil vishnoianil moved this to Ready in UI Nov 21, 2024
@vishnoianil vishnoianil added this to the release-1.1 milestone Nov 21, 2024
@vishnoianil vishnoianil self-assigned this Dec 18, 2024
@vishnoianil vishnoianil moved this from Ready to In progress in UI Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tech debt UX Related to the user experience
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants