Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing Index to #ic-tab does not initialize properly #9

Open
rtablada opened this issue Aug 20, 2014 · 1 comment
Open

Passing Index to #ic-tab does not initialize properly #9

rtablada opened this issue Aug 20, 2014 · 1 comment

Comments

@rtablada
Copy link

When passing a custom index to ic-tab components, the tabs list does not initialize as expected.
Clicking on a tab does update the property to the custom index, but no tab is selected by default.

Code modification of example:

  {{#ic-tabs selected-index=food}}
    {{#ic-tab-list}}
      {{#ic-tab index="hamburger"}}Hamburger{{/ic-tab}}
      {{#ic-tab index="noodles"}}Noodles{{/ic-tab}}
      {{#ic-tab index="toast"}}Toast{{/ic-tab}}
    {{/ic-tab-list}}

    {{#ic-tab-panel}}
      <h2>Hamburger</h2>
      <p>
        Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod
        tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim
        veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea
        commodo consequat. Duis aute irure dolor in reprehenderit in voluptate
        velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint
        occaecat cupidatat non proident, sunt in culpa qui officia deserunt
        mollit anim id est laborum.
      </p>
    {{/ic-tab-panel}}

    {{#ic-tab-panel}}
      <h2>Noodles</h2>
      <p>
        Tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim
        veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea
        commodo consequat. Duis aute irure dolor in reprehenderit in voluptate
        velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint
        occaecat cupidatat non proident, sunt in culpa qui officia deserunt
        mollit anim id est laborum.
      </p>
    {{/ic-tab-panel}}

    {{#ic-tab-panel}}
      <h2>Toast</h2>
      <p>
        Veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea
        commodo consequat. Duis aute irure dolor in reprehenderit in voluptate
        velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint
        occaecat cupidatat non proident, sunt in culpa qui officia deserunt
        mollit anim id est laborum.
        Tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim.
      </p>
    {{/ic-tab-panel}}
  {{/ic-tabs}}
  App.ApplicationController = Ember.Controller.extend({
    queryParams: ['country', 'food'],
    country: 0,
    food: 'hamburger'
  });
@rtablada
Copy link
Author

@rpflorence is there any plan on continuing development of ic-tabs? And would you be interested in allowing custom string indexes for better query param urls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant