Removes the superfluous update func now that we are calcualting stored date diff in read

Author: nickfloyd

github/resource_github_actions_organization_secret.go

@@ -16,7 +16,6 @@ func resourceGithubActionsOrganizationSecret() *schema.Resource {
 	return &schema.Resource{
 		Create: resourceGithubActionsOrganizationSecretCreateOrUpdate,
 		Read:   resourceGithubActionsOrganizationSecretRead,
-		Update: resourceGithubActionsOrganizationSecretCreateOrUpdate,
 		Delete: resourceGithubActionsOrganizationSecretDelete,
 		Importer: &schema.ResourceImporter{
 			State: func(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) {

github/resource_github_actions_organization_secret_test.go

@@ -268,15 +268,9 @@ func TestAccGithubActionsOrganizationSecret(t *testing.T) {
 		}
 	})
 
-	t.Run("destroy_on_drift requires ForceNew due to Update function", func(t *testing.T) {
-		// Test that destroy_on_drift field has ForceNew: true 
-		// This is required because we have an Update function defined  
+	t.Run("destroy_on_drift field defaults", func(t *testing.T) {
+		// Test that destroy_on_drift defaults to true for backward compatibility
 		schema := resourceGithubActionsOrganizationSecret().Schema["destroy_on_drift"]
-		if !schema.ForceNew {
-			t.Error("destroy_on_drift field must have ForceNew: true when Update function is defined, to avoid 'Provider produced inconsistent result' errors")
-		}
-
-		// Test that it defaults to true
 		if schema.Default != true {
 			t.Error("destroy_on_drift should default to true for backward compatibility")
 		}

github/resource_github_actions_secret.go

@@ -17,7 +17,6 @@ func resourceGithubActionsSecret() *schema.Resource {
 	return &schema.Resource{
 		Create: resourceGithubActionsSecretCreateOrUpdate,
 		Read:   resourceGithubActionsSecretRead,
-		Update: resourceGithubActionsSecretCreateOrUpdate,
 		Delete: resourceGithubActionsSecretDelete,
 		Importer: &schema.ResourceImporter{
 			State: resourceGithubActionsSecretImport,

github/resource_github_actions_secret_test.go

@@ -513,15 +513,9 @@ func TestGithubActionsSecretDriftDetection(t *testing.T) {
 		}
 	})
 
-	t.Run("destroy_on_drift requires ForceNew due to Update function", func(t *testing.T) {
-		// Test that destroy_on_drift field has ForceNew: true 
-		// This is required because we have an Update function defined
+	t.Run("destroy_on_drift field defaults", func(t *testing.T) {
+		// Test that destroy_on_drift defaults to true for backward compatibility
 		schema := resourceGithubActionsSecret().Schema["destroy_on_drift"]
-		if !schema.ForceNew {
-			t.Error("destroy_on_drift field must have ForceNew: true when Update function is defined, to avoid 'Provider produced inconsistent result' errors")
-		}
-
-		// Test that it defaults to true
 		if schema.Default != true {
 			t.Error("destroy_on_drift should default to true for backward compatibility")
 		}