Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Local Dataflow Handling and Analysis #301

Open
lab596 opened this issue Aug 26, 2023 · 0 comments
Open

Enhance Local Dataflow Handling and Analysis #301

lab596 opened this issue Aug 26, 2023 · 0 comments

Comments

@lab596
Copy link
Contributor

lab596 commented Aug 26, 2023

In the file visa/LocalDataflow.h, there's a TODO statement that suggests improving the handling of Local Dataflow and turning it into a class. The TODO also mentions an assumption about escaped instructions and a potential change from a map to a vector or set. I was wondering if the implementation of this is complete yet.

TODO Statement:

Line19: // ToDo: move Local dataflow here and make it a class

Line 39: // If BB is not in the map, it means we need to run analysis for this BB
  // ToDo: assumption is that there should not be many escaped inst. Can change
  // to vector to set later if desired.

It would be beneficial to address this TODO by implementing the proposed changes. By moving Local Dataflow into a class and optimizing the analysis process, we can potentially improve the efficiency and maintainability of the code.

I do not have the coding knowledge to implement this change, but I would love to learn. Any advice is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant