Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid MCO for vfio-pci. Find more elegent way to load vfio-pci by default #136

Open
mregmi opened this issue Sep 13, 2023 · 3 comments
Open
Assignees
Labels
enhancement New feature or request qat QAT feature

Comments

@mregmi
Copy link
Contributor

mregmi commented Sep 13, 2023

Issue:
vfio-pci driver is needed by QAT and needs to be loaded before plugin is deployed. For now there is a MCO that loads the driver. We want to move away from the MCO.

Potential solution
We can load the vfio-pci driver using initcontainers.

@hershpa hershpa added enhancement New feature or request qat QAT feature labels Sep 13, 2023
@mythi
Copy link

mythi commented Sep 14, 2023

We want to move away from the MCO.

It's not clear why this is the goal. How do you plan to get rid of setting kernel cmdline args for intel_iommu etc?

@uMartinXu
Copy link
Contributor

uMartinXu commented Sep 15, 2023

We want to move away from the MCO.

It's not clear why this is the goal. How do you plan to get rid of setting kernel cmdline args for intel_iommu etc?

To achieve the final bootless goal.
If we can't make the intel_iommu as the default kernel parameter for RHCOS. We will figure out a way and suggest user use this way to set it as the default parameter on day 1 when the user provisions the cluster.

@mythi
Copy link

mythi commented Sep 18, 2023

If we can't make the intel_iommu as the default kernel parameter for RHCOS.

It's probably not going to work out because this may need to be modifiable depending on the features users want.

For DSA/IAA, you are already going to need intel_iommu=on,sm_on but some may also want to turn if off intel_iommu=on,sm_off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qat QAT feature
Projects
None yet
Development

No branches or pull requests

4 participants