Pin benchmarks to 4 cores in all suites

Author: PatKamin

devops/scripts/benchmarks/benches/base.py

@@ -6,15 +6,18 @@
 import os
 import shutil
 import subprocess
-from pathlib import Path
+from abc import ABC, abstractmethod
 from enum import Enum
-from utils.result import BenchmarkMetadata, BenchmarkTag, Result
+from pathlib import Path
+
+from psutil import Process
+
 from options import options
-from utils.utils import download, run
-from abc import ABC, abstractmethod
-from utils.unitrace import get_unitrace
 from utils.flamegraph import get_flamegraph
 from utils.logger import log
+from utils.result import BenchmarkMetadata, BenchmarkTag, Result
+from utils.unitrace import get_unitrace
+from utils.utils import download, run
 
 
 class TracingType(Enum):
@@ -167,6 +170,8 @@ def run_bench(
             log.debug(f"FlameGraph perf data: {perf_data_file}")
             log.debug(f"FlameGraph command: {' '.join(command)}")
 
+        command = self.taskset_cmd() + command
+
         try:
             result = run(
                 command=command,
@@ -268,6 +273,24 @@ def get_metadata(self) -> dict[str, BenchmarkMetadata]:
             )
         }
 
+    def taskset_cmd(self) -> list[str]:
+        """Returns a list of strings with taskset usage for core pinning.
+        Pin compute benchmarks to a CPU cores set to ensure consistent results
+        and non-zero CPU count measurements (e.g. avoid E-cores). Exactly 4 cores
+        with the maximum frequency are pinned by default to satisfy multiple threads benchmarks.
+        """
+        available_cores = Process().cpu_affinity()
+        core_frequencies = []
+        for core in available_cores:  # type: ignore
+            with open(
+                f"/sys/devices/system/cpu/cpu{core}/cpufreq/cpuinfo_max_freq"
+            ) as f:
+                freq = int(f.read().strip())
+                core_frequencies.append((core, freq))
+        core_frequencies.sort(key=lambda x: x[1], reverse=True)
+        cores_list = ",".join([str(core) for core, _ in core_frequencies[:4]])
+        return ["taskset", "-c", cores_list]
+
 
 class Suite(ABC):
     @abstractmethod

devops/scripts/benchmarks/benches/compute.py

@@ -3,14 +3,12 @@
 # See LICENSE.TXT
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
-import copy
 import csv
 import io
 import math
 from enum import Enum
 from itertools import product
 from pathlib import Path
-from psutil import Process
 
 from git_project import GitProject
 from options import options
@@ -418,24 +416,6 @@ def run(
         command += self.bin_args(run_trace)
         env_vars.update(self.extra_env_vars())
 
-        # Pin compute benchmarks to a CPU cores set to ensure consistent results
-        # and non-zero CPU count measurements (e.g. avoid E-cores). 4 max freq cores
-        # are pinned by default to satisfy multiple threads benchmarks.
-        available_cores = Process().cpu_affinity()
-        # Get 4 cores with the highest available frequency.
-        core_frequencies = []
-        for core in available_cores:
-            with open(
-                f"/sys/devices/system/cpu/cpu{core}/cpufreq/cpuinfo_max_freq"
-            ) as f:
-                freq = int(f.read().strip())
-                core_frequencies.append((core, freq))
-        core_frequencies.sort(key=lambda x: x[1], reverse=True)
-        available_cores = [core for core, _ in core_frequencies[:4]]
-        cores_list = ",".join([str(core) for core in available_cores])
-
-        command = ["taskset", "-c", cores_list] + command
-
         result = self.run_bench(
             command, env_vars, run_trace=run_trace, force_trace=force_trace
         )