Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structural pattern matching in lit.cfg.py #16211

Open
0x12CC opened this issue Nov 28, 2024 · 0 comments · May be fixed by #16217
Open

Structural pattern matching in lit.cfg.py #16211

0x12CC opened this issue Nov 28, 2024 · 0 comments · May be fixed by #16217
Labels
bug Something isn't working confirmed infrastructure

Comments

@0x12CC
Copy link
Contributor

0x12CC commented Nov 28, 2024

Describe the bug

#16016 added this line to our lit.cfg.py:

llvm/sycl/test-e2e/lit.cfg.py

Line 41 in 77abc08

match lit_config.params.get("test-mode", "full"):

Pattern matching requires Python 3.10 but our testing requirements page states that we need Python 3.8: https://github.com/intel/llvm/blob/sycl/llvm/docs/TestingGuide.rst#requirements. This causes Python errors when running tests on a system with Python 3.8 or 3.9.

To reproduce

Run the following command on a system with Python 3.8:

ninja check-sycl-e2e

Environment

  • OS: Linux
  • Target device and vendor: N/A
  • DPC++ version: f279a8a
  • Dependencies version: N/A

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working confirmed infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SYCL][E2E] Change pattern matching to if-else statements in lit.cfg.py ayylol/intel-llvm
1 participant
@0x12CC