[DeviceMSAN] Support MemorySanitizer for device offloading #15955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
reviewed
Nov 20, 2024
zhaomaosu
reviewed
Nov 20, 2024
zhaomaosu
reviewed
Nov 20, 2024
zhaomaosu
reviewed
Nov 20, 2024
zhaomaosu
reviewed
Nov 20, 2024
zhaomaosu
reviewed
Nov 20, 2024
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Hi @intel/llvm-reviewers-runtime |
zhaomaosu
reviewed
Nov 26, 2024
| @@ -790,6 +791,13 @@ processInputModule(std::unique_ptr<Module> M) { | |||
| if (M->getTargetTriple().find("spir") != std::string::npos) | |||
| Modified |= removeDeviceGlobalFromCompilerUsed(*M.get()); | |||
|
|
|||
| // AddressSanitizer specific passes | |||
There was a problem hiding this comment.
MemorySanitizer? And should the line 797 is MsanKernel?
There was a problem hiding this comment.
MemorySanitizer? And should the line 797 is MsanKernel?
I'm going to unify "AsanKernelMetadata" and "MsanKernelMetadata", so I used a more general name here.
yingcong-wu
reviewed
Nov 26, 2024
clang/lib/Driver/OffloadBundler.cpp
Outdated
| // the list of defined symbols. | ||
| if (SF->isIR() && | ||
| (Name == "llvm.used" || Name == "llvm.compiler.used" || | ||
| Name == "__AsanDeviceGlobalMetadata")) | ||
| Name == "__AsanDeviceGlobalMetadata" || | ||
| Name == "__MsanKernelMetadata")) |
There was a problem hiding this comment.
Why the name is different for ASAN and MSAN?
There was a problem hiding this comment.
Good idea. I will merge them in other patch.
There was a problem hiding this comment.
Currently, I handle them all in SanitizerKernelMetadata Pass, and don't use a same name, because I'm not sure if their content will be different.
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR: oneapi-src/unified-runtime#2325