[SYCL][Graph] Enable host-task update in graphs #16853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bensuo
commented
Jan 31, 2025
Bensuo
commented
- Update spec wording to allow updating host-task function in graphs
- Support host-tasks in dynamic command-groups
- Support host-tasks in whole graph update
- Add E2E tests for both scenarios
- Fix passing incorrect accessors to graph update command after update which could cause issues if the graph was destroyed while the scheduler still had graph execution commands alive
Bensuo
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Bensuo
force-pushed
the
ben/whole-graph-host-task
branch
from
e9b4148 to
fd83dfe
Compare
|
Fixed now. |
- Update spec wording to allow updating host-task function in graphs - Support host-tasks in dynamic command-groups - Support host-tasks in whole graph update - Add E2E tests for both scenarios - Fix passing incorrect accessors to graph update command after update
- Instead of trying to update host tasks through scheduler, simply do host-task updates immediately before scheduling the rest of the commands.
Bensuo
force-pushed
the
ben/whole-graph-host-task
branch
from
de6a71e to
bc20c32
Compare
EwanC
reviewed
Feb 14, 2025
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
- Fix errors in spec - Fix commented out code in test
|
@KseniyaTikhomirova Sorry for the delay, this is ready for review now. |
KseniyaTikhomirova
approved these changes
Feb 18, 2025
|
@intel/llvm-gatekeepers This is good to merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.