Skip to content

[Joint matrix] Remove cpu-unsupported shapes/layouts in Matrix tests. #19475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: sycl
Choose a base branch
from
Open

[Joint matrix] Remove cpu-unsupported shapes/layouts in Matrix tests. #19475

wants to merge 6 commits into from

Conversation

ggojska
Copy link
Contributor

@ggojska ggojska commented Jul 16, 2025 •
edited by dkhaldi
Loading

No description provided.

@ggojska ggojska requested a review from a team as a code owner July 16, 2025 13:46
@ggojska ggojska temporarily deployed to WindowsCILock July 16, 2025 13:46 — with GitHub Actions Inactive
@ggojska ggojska changed the title [Joint matrix] Remove unsupported shapes/layouts in Matrix tests. [Joint matrix] Remove cpu-unsupported shapes/layouts in Matrix tests. Jul 16, 2025
@ggojska ggojska self-assigned this Jul 16, 2025
dkhaldi
dkhaldi reviewed Jul 16, 2025
View reviewed changes
@ggojska ggojska marked this pull request as draft July 16, 2025 14:05
dkhaldi
dkhaldi reviewed Jul 16, 2025
View reviewed changes
@ggojska ggojska temporarily deployed to WindowsCILock July 16, 2025 14:21 — with GitHub Actions Inactive
@ggojska ggojska temporarily deployed to WindowsCILock July 17, 2025 14:42 — with GitHub Actions Inactive
@ggojska ggojska temporarily deployed to WindowsCILock July 17, 2025 15:39 — with GitHub Actions Inactive
@ggojska ggojska temporarily deployed to WindowsCILock July 17, 2025 15:39 — with GitHub Actions Inactive
dkhaldi
dkhaldi reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the two extra combinations to bfloat16 test in SG32.

sycl/test-e2e/Matrix/SG32/joint_matrix_half.cpp Outdated
// test<half, float, float, /*TM*/ 16, /*TN*/ 16, /*TK*/ 16,
// layout::row_major, 2>();
// test<half, float, float, /*TM*/ 16, /*TN*/ 16, /*TK*/ 32,
// layout::row_major, 2>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// layout::row_major, 2>();
// layout::row_major, 1>();

sycl/test-e2e/Matrix/joint_matrix_bfloat16.cpp Outdated
test<bfloat16, float, float, /*TM*/ 16, /*TN*/ 16, /*TK*/ 16,
layout::row_major, 2>();
test<bfloat16, float, float, /*TM*/ 16, /*TN*/ 16, /*TK*/ 32,
layout::row_major, 2>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
layout::row_major, 2>();
layout::row_major, 1>();

@ggojska ggojska temporarily deployed to WindowsCILock July 18, 2025 16:23 — with GitHub Actions Inactive
@ggojska ggojska temporarily deployed to WindowsCILock July 18, 2025 16:43 — with GitHub Actions Inactive
@ggojska ggojska temporarily deployed to WindowsCILock July 18, 2025 16:43 — with GitHub Actions Inactive
@dkhaldi dkhaldi marked this pull request as ready for review July 18, 2025 21:38
dkhaldi
dkhaldi approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhaldi dkhaldi dkhaldi approved these changes

Assignees

@ggojska ggojska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggojska @dkhaldi