From 81d4d60de6e8ad3e475324d4251b15b9cda47213 Mon Sep 17 00:00:00 2001 From: Cai_Jianxing Date: Tue, 12 Sep 2023 22:14:20 +0800 Subject: [PATCH] [VP] fix coverity issue 5 fix coverity issue5 --- .../hal/platform_interface/vp_platform_interface.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/media_softlet/agnostic/common/vp/hal/platform_interface/vp_platform_interface.cpp b/media_softlet/agnostic/common/vp/hal/platform_interface/vp_platform_interface.cpp index 1e0f6a68a8..8948cb87b2 100644 --- a/media_softlet/agnostic/common/vp/hal/platform_interface/vp_platform_interface.cpp +++ b/media_softlet/agnostic/common/vp/hal/platform_interface/vp_platform_interface.cpp @@ -421,6 +421,7 @@ MOS_STATUS VpPlatformInterface::InitVpCmKernels( if (kernel->getName() == nullptr || kernel->getNameLen() < 1 || kernel->getNameLen() > 256) { + MOS_Delete(isaFile); VP_PUBLIC_CHK_STATUS_RETURN(MOS_STATUS_INVALID_PARAMETER); } @@ -455,14 +456,19 @@ MOS_STATUS VpPlatformInterface::InitVpCmKernels( if (kernelBody->getNumInputs() > CM_MAX_ARGS_PER_KERNEL) { - return MOS_STATUS_INVALID_PARAMETER; + MOS_Delete(isaFile); + VP_PUBLIC_CHK_STATUS_RETURN(MOS_STATUS_INVALID_PARAMETER); } for (uint32_t j = 0; j < kernelBody->getNumInputs(); j++) { KRN_ARG kernelArg = {}; vISA::InputInfo *inputInfo = kernelBody->getInputInfo()[j]; - VP_PUBLIC_CHK_NULL_RETURN(inputInfo); + if (!inputInfo) + { + MOS_Delete(isaFile); + VP_PUBLIC_CHK_STATUS_RETURN(MOS_STATUS_NULL_POINTER); + } uint8_t kind = inputInfo->getKind(); if (kind == 0x2) // compiler value for surface