fix: Update feature type imports and improve type annotations in NetworkAdapterOwner and ARP feature

Signed-off-by: Lasota, Adrian <[email protected]>

Author: adrianlasota

README.md

@@ -119,6 +119,7 @@ To filter out specific Network Interfaces you can use following combinations of
 3) (`pci_device`|`family`|`speed`|`family`+`speed`) + (`random_interface`|`all_interfaces`)
 4) (`random_interface`|`all_interfaces`) 
 5) `interface_names`
+6) `mac_address`
 
 - `family`:
   - key of `DEVICE_IDS` from `mfd-const` e.g. `CPK`, `FVL`
@@ -144,6 +145,7 @@ def get_interfaces(
         random_interface: Optional[bool] = None,
         all_interfaces: Optional[bool] = None,
         namespace: Optional[str] = None,
+        mac_address:  MACAddress | None = None
     ) -> List["NetworkInterface"]
 ```
 
@@ -159,6 +161,7 @@ Expected combinations are:
 1) interface_name
 2) pci_address
 3) pci_device / family / speed + interface_index
+4) mac_address
 
 * source code:
 ```python
@@ -172,6 +175,7 @@ def get_interface(
         interface_index: Optional[int] = None,
         interface_name: Optional[str] = None,
         namespace: Optional[str] = None,
+        mac_address:  MACAddress | None = None
     ) -> "NetworkInterface"
 ```
 

mfd_network_adapter/network_adapter_owner/base.py

@@ -49,8 +49,8 @@
     from .feature.ans import AnsFeatureType
     from .feature.cpu import CPUFeatureType
     from .feature.mac import MACFeatureType
-    from .feature.geneve import GeneveFeatureType
-    from .feature.gtp import GTPFeatureType
+    from .feature.geneve import GeneveTunnelFeatureType
+    from .feature.gtp import GTPTunnelFeatureType
 
 logger = logging.getLogger(__name__)
 add_logging_level(level_name="MODULE_DEBUG", level_value=log_levels.MODULE_DEBUG)
@@ -103,7 +103,7 @@ def __init__(self, *, connection: "Connection", **kwargs):
         # features of owner to be lazy initialized
         self._arp: "ARPFeatureType | None" = None
         self._dcb: "LinuxDcb | WindowsDcb | None" = None
-        self._driver: "DriverFeatureType " | None = None
+        self._driver: "DriverFeatureType | None" = None
         self._firewall: "FirewallFeatureType | None" = None
         self._ip: "IPFeatureType | None" = None
         self._nm: "NMFeatureType | None" = None
@@ -122,8 +122,8 @@ def __init__(self, *, connection: "Connection", **kwargs):
         self._ans: "AnsFeatureType | None" = None
         self._cpu: "CPUFeatureType | None" = None
         self._mac: "MACFeatureType | None" = None
-        self._geneve: "GeneveFeatureType | None" = None
-        self._gtp: "GTPFeatureType | None" = None
+        self._geneve: "GeneveTunnelFeatureType | None" = None
+        self._gtp: "GTPTunnelFeatureType | None" = None
 
     @property
     def arp(self) -> "ARPFeatureType":
@@ -136,7 +136,7 @@ def arp(self) -> "ARPFeatureType":
         return self._arp
 
     @property
-    def dcb(self) -> Union["Dcb", "LinuxDcb", "WindowsDcb"]:
+    def dcb(self) -> "Dcb | LinuxDcb | WindowsDcb":
         """DCB feature."""
         if self._dcb is None:
             from mfd_dcb import Dcb
@@ -336,7 +336,7 @@ def mac(self) -> "MACFeatureType":
         return self._mac
 
     @property
-    def geneve(self) -> "GeneveFeatureType":
+    def geneve(self) -> "GeneveTunnelFeatureType":
         """Geneve Tunnel feature."""
         if self._geneve is None:
             from .feature.geneve import BaseGeneveTunnelFeature
@@ -346,7 +346,7 @@ def geneve(self) -> "GeneveFeatureType":
         return self._geneve
 
     @property
-    def gtp(self) -> "GTPFeatureType":
+    def gtp(self) -> "GTPTunnelFeatureType":
         """GTP Tunnel feature."""
         if self._gtp is None:
             from .feature.gtp import BaseGTPTunnelFeature

mfd_network_adapter/network_adapter_owner/feature/arp/__init__.py

@@ -2,12 +2,10 @@
 # SPDX-License-Identifier: MIT
 """Module for ARP feature."""
 
-from typing import Union
-
 from .base import BaseARPFeature
 from .esxi import ESXiARPFeature
 from .freebsd import FreeBSDARPFeature
 from .linux import LinuxARPFeature
 from .windows import WindowsARPFeature
 
-ARPFeatureType = Union[LinuxARPFeature, WindowsARPFeature, FreeBSDARPFeature, ESXiARPFeature]
+ARPFeatureType = BaseARPFeature | LinuxARPFeature | WindowsARPFeature | FreeBSDARPFeature | ESXiARPFeature