You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After some more investigation, it's now clear that we validate that columns are convertible to numeric values (with _require_numeric) but don't actually perform the conversion.
Expected behavior
We should either:
fom
) are actually numeric, and raise an exception if the condition does not hold; orto_numeric
) and raise an exception if the conversion fails.Actual behavior
Loading data from an outside source (like JSON) that stores FOM information as strings can lead to strange results, because:
Steps to reproduce the problem
Use string representations of the FOM instead of numeric ones.
Specifications
Tested with the tip of
main
.The text was updated successfully, but these errors were encountered: