Skip to content

layernorm: enlarge the range for 2-pass reduction #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

layernorm: enlarge the range for 2-pass reduction #2282

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9403eed
enlarge the range for 2-pass reduction
weishi-deng Nov 4, 2025
d072252
update config logic
weishi-deng Nov 4, 2025
98ccf83
Update src/ATen/native/xpu/sycl/LayerNormKernels.cpp
weishi-deng Nov 5, 2025
7f6f9a8
update condition for 2 pass
weishi-deng Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/ATen/native/xpu/sycl/LayerNormKernels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,8 +1063,10 @@ void _layer_norm_backward_kernel(
norm_config_global_size / syclMaxSubGroupSize() * 2 <= thread_slots;
// cuda uses condition M > 64 * 1024 && N / 32 < sm_count / 2 to parallelize
// in the M dimension
if (use_two_stage_col_reduction && M > 64 * 1024 &&
N / 32 < syclGpuEuCount() / syclGpuEUCountPerSubslice() / 2) {
int xe_core_count = syclGpuEuCount() / syclGpuEUCountPerSubslice();
int tile_n = N / 32;
if (use_two_stage_col_reduction && M > xe_core_count * 1024 &&
tile_n < xe_core_count * 2) {
const size_t local_size_x = 8;
const size_t SIMD = 32;
// workgroup size is 256
Expand Down
Loading