Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow profiling to be toggled using a config flag instead of adding/removing a decorator #312

Open
jarlsondre opened this issue Feb 3, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jarlsondre
Copy link
Collaborator

Summary

If you wish to turn itwinai's profiling functionality on or off, you currently have to add or remove a decorator. This is quite cumbersome, as one shouldn't have to manually change the code just to toggle a configuration setting. Additionally, it is problematic as you also have to remove the import of the decorator in most cases—at least for the linter not to fail.

Potential Solution: This can be solved by adding a field in the TorchTrainer that the decorator can use to decide whether or not to activate. This field can easily be passed to the TorchTrainer from a configuration, thus solving the problem.

@jarlsondre jarlsondre added the enhancement New feature or request label Feb 3, 2025
@jarlsondre jarlsondre self-assigned this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant