Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper Secret Handling for MongoDB #43

Open
RMichaelSwan opened this issue May 10, 2021 · 0 comments
Open

Proper Secret Handling for MongoDB #43

RMichaelSwan opened this issue May 10, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@RMichaelSwan
Copy link
Collaborator

RMichaelSwan commented May 10, 2021 •
edited
Loading

Need to grab secret credentials in a similar way as GCS and AWS credentials are grabbed so that they don't get accidentally committed (also a possible security issue in the future).

Offending code:

HARMONI/harmoni_core/harmoni_recorder/src/harmoni_recorder/template_storedata.py

Line 14 in 609f52a

mdb_client = MongoDBClient(client_uri="mongodb://172.18.3.3:27017/", username="root", password="example")

Originally posted by @RMichaelSwan in #41 (comment)
@RMichaelSwan RMichaelSwan added the enhancement New feature or request label May 10, 2021
This was referenced May 10, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RMichaelSwan