Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move currency specific constants/methods from lib to monetary #512

Open
bvotteler opened this issue Dec 21, 2022 · 0 comments
Open

Move currency specific constants/methods from lib to monetary #512

bvotteler opened this issue Dec 21, 2022 · 0 comments
Labels
prio:low

Comments

@bvotteler
Copy link
Contributor

  1. Move ATOMIC_UNIT constant to monetary
    See PR comment: Chore: Update monetary-js, and remove currency units #435 (review)

  2. Recreate atomicToBaseAmount() in monetary
    See PR comment: Chore: Update monetary-js, and remove currency units #435 (review)

  3. Recreate static method newMonetaryAmount() (in src/util/currency.ts) in monetary-js

  4. Mark recreated methods as @deprecated to be removed in future updates
@nud3l nud3l added this to Backlog Jan 3, 2023
@nud3l nud3l moved this to Todo ⏳ in Backlog Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio:low
Projects
Backlog
Status: Todo ⏳
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bvotteler