Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaults should only register up to collateral ceiling #425

Open
gregdhill opened this issue Dec 6, 2022 · 0 comments
Open

Vaults should only register up to collateral ceiling #425

gregdhill opened this issue Dec 6, 2022 · 0 comments

Comments

@gregdhill
Copy link
Member

Is your feature request related to a problem? Please describe.
Vault registration will fail when using the faucet if the amount exceeds the free balance or currency ceiling.

Describe the solution you'd like
The Vault should use the maximum possible value (i.e. max(ceiling - total_collateral, max(amount, free_balance))) to prevent exiting early.

Additional context
This may actually be preferable behavior since otherwise the operator will not know that the full amount was not locked.

@nud3l nud3l added this to Backlog Jan 3, 2023
@nud3l nud3l moved this to Todo ⏳ in Backlog Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant