Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swap] Clean up form on changing account #954

Open
danielsimao opened this issue Feb 16, 2023 · 2 comments
Open

[Swap] Clean up form on changing account #954

danielsimao opened this issue Feb 16, 2023 · 2 comments
Assignees
@danielsimao
Labels
prio:low testnet-competition Bugs reported during testnet competition
Milestone
Tech debt

Comments

@danielsimao
Copy link
Member

Describe the bug
Currently the swap form is not clean up when account is changed

To Reproduce
Steps to reproduce the behavior:

  1. Go to swap page
  2. Setup a trade
  3. Change account
  4. See that trade persists

Expected behavior
Should clean up UI to default.
@danielsimao danielsimao added prio:low testnet-competition Bugs reported during testnet competition labels Feb 16, 2023
@github-project-automation github-project-automation bot moved this to New 🆕 in Backlog Feb 16, 2023
@nud3l nud3l moved this from New 🆕 to Todo ⏳ in Backlog Feb 20, 2023
@tomjeatt tomjeatt added this to the Tech debt milestone Feb 21, 2023
@danielsimao
Copy link
Member Author

@nud3l I kinda changed my mind of this. Do you think this should really happen?

@nud3l
Copy link
Member

nud3l commented Mar 2, 2023

Who requested that feature? For me both is OK but if many users requested it, we might still want to change it.

@danielsimao danielsimao self-assigned this Jul 17, 2023
@danielsimao danielsimao linked a pull request Jul 17, 2023 that will close this issue
fix: update form state according to balance #1459
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielsimao danielsimao

Labels
prio:low testnet-competition Bugs reported during testnet competition
Projects
Backlog
Status: Todo ⏳
Milestone
Tech debt
Development

Successfully merging a pull request may close this issue.

fix: update form state according to balance interlay/interbtc-ui
3 participants
@nud3l @tomjeatt @danielsimao