Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update dependencies to polkadot v1 release #1149

Merged
merged 9 commits into from
Sep 20, 2023
Merged

feat: update dependencies to polkadot v1 release #1149

merged 9 commits into from
Sep 20, 2023

Conversation

nakul1010
Copy link
Member

@nakul1010 nakul1010 commented Jul 31, 2023 •
edited
Loading

Closes #1148

The Major changes in the code

  • Adds serve feature flag to the primitives. This way, serde (de)serialization can also be used in no_std environments. (PR 1307)
  • Remove node Cli Parameters (Done in 0.9.43 release )
  • Update GenesisConfig (Helping PRs- 14108)

For more info on the release, check out the tag here

Release Analysis

@nakul1010 nakul1010 changed the title fest: update to v1 fest: update dependencies to polkadot v1 release Jul 31, 2023
@nakul1010 nakul1010 marked this pull request as draft July 31, 2023 10:41
@nakul1010 nakul1010 force-pushed the nakul/feat_update_to_v1 branch 2 times, most recently from 79539db to 77ba8e4 Compare August 1, 2023 09:42
@nakul1010 nakul1010 self-assigned this Aug 1, 2023
@nakul1010 nakul1010 changed the title fest: update dependencies to polkadot v1 release feat: update dependencies to polkadot v1 release Aug 1, 2023
@nakul1010 nakul1010 force-pushed the nakul/feat_update_to_v1 branch from 4bb8329 to 8f82a9a Compare August 1, 2023 20:02
@nakul1010
Copy link
Member Author

blocked by ORML issue

@nakul1010 nakul1010 added the blocked The pull request is currently blocked due to another issue or upstream dependency. label Aug 1, 2023
@nakul1010
Copy link
Member Author

The PR is unblocked as ORML dependencies are updated to 1.0.0.
Reference PR

@nakul1010 nakul1010 added inProgress The PR is still in progress and removed blocked The pull request is currently blocked due to another issue or upstream dependency. labels Aug 7, 2023
@nakul1010 nakul1010 force-pushed the nakul/feat_update_to_v1 branch from e8608a5 to 79a25f5 Compare August 8, 2023 08:22
@nakul1010
Copy link
Member Author

nakul1010 commented Aug 9, 2023 •
edited
Loading

Blocked by mocktopus crate dependency

@nakul1010 nakul1010 added blocked The pull request is currently blocked due to another issue or upstream dependency. and removed inProgress The PR is still in progress labels Aug 9, 2023
@nakul1010 nakul1010 added inProgress The PR is still in progress and removed blocked The pull request is currently blocked due to another issue or upstream dependency. labels Aug 21, 2023
@gregdhill gregdhill force-pushed the nakul/feat_update_to_v1 branch from 293a57d to 4e65b7a Compare August 24, 2023 12:45
@nakul1010
Copy link
Member Author

Blocked by mocktopus crate dependency

Shifted back to the previous nightly version, which resolves the error, after the mocktopus issue is resolved can shift to latest nightly version.

@nakul1010 nakul1010 added ReviewNeeded The PR can be reviewed by peers and removed inProgress The PR is still in progress labels Aug 30, 2023
@nakul1010 nakul1010 marked this pull request as ready for review August 30, 2023 12:09
gregdhill
gregdhill reviewed Aug 30, 2023
View reviewed changes
.github/workflows/cargo-test.yml Show resolved Hide resolved
crates/annuity/src/mock.rs Outdated Show resolved Hide resolved
crates/annuity/src/mock.rs Show resolved Hide resolved
crates/annuity/src/tests.rs Show resolved Hide resolved
rpc/src/eth.rs Outdated Show resolved Hide resolved
parachain/runtime/runtime-tests/src/parachain/contracts.rs Outdated Show resolved Hide resolved
parachain/runtime/runtime-tests/src/parachain/contracts.rs Outdated Show resolved Hide resolved
parachain/runtime/runtime-tests/src/relaychain/mod.rs Outdated Show resolved Hide resolved
parachain/src/eth.rs Outdated Show resolved Hide resolved
parachain/src/service.rs Show resolved Hide resolved
@nakul1010 nakul1010 mentioned this pull request Aug 31, 2023
Open
@nakul1010 nakul1010 force-pushed the nakul/feat_update_to_v1 branch from 21e6692 to fde2626 Compare September 5, 2023 06:55
@nakul1010 nakul1010 force-pushed the nakul/feat_update_to_v1 branch from fde2626 to 76ae882 Compare September 5, 2023 06:57
@nakul1010
Merge branch 'master' of https://github.com/interlay/interbtc into na…
6a85c2b 
…kul/feat_update_to_v1

# Conflicts:
#	Cargo.lock
#	parachain/runtime/kintsugi/src/contracts.rs
#	parachain/runtime/kintsugi/src/lib.rs
#	parachain/src/service.rs
@nakul1010 nakul1010 mentioned this pull request Sep 5, 2023
Open
@nakul1010 nakul1010 requested a review from sander2 September 5, 2023 10:30
sander2
sander2 reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@sander2 sander2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if you're aware of these, but imo they're very helpful. Can you also put them in the pr info?

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-43/3158
https://forum.polkadot.network/t/polkadot-release-analysis-v1-0-0/3585

parachain/runtime/kintsugi/src/lib.rs Show resolved Hide resolved
parachain/runtime/kintsugi/src/lib.rs Show resolved Hide resolved
parachain/runtime/kintsugi/src/lib.rs Show resolved Hide resolved
crates/bitcoin/src/address.rs Show resolved Hide resolved
crates/bitcoin/src/formatter.rs Show resolved Hide resolved
@sander2
Copy link
Member

sander2 commented Sep 5, 2023

And can you make a ticket to address paritytech/substrate#13958 please

@nakul1010 nakul1010 requested a review from sander2 September 6, 2023 06:34
@nakul1010
Copy link
Member Author

nakul1010 commented Sep 20, 2023 •
edited
Loading

And can you make a ticket to address paritytech/substrate#13958 please

Yes opened #1197, but currently i see we are taking the proof_size from cumulus_primitives here, should it be calculated based on interlay parachain block fullness?

@nakul1010 nakul1010 mentioned this pull request Sep 20, 2023
Open
4 tasks
@gregdhill gregdhill merged commit 82359fa into master Sep 20, 2023
3 checks passed
@gregdhill gregdhill deleted the nakul/feat_update_to_v1 branch September 20, 2023 09:58
@nakul1010 nakul1010 mentioned this pull request Sep 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregdhill gregdhill gregdhill approved these changes

@sander2 sander2 Awaiting requested review from sander2

Assignees

@nakul1010 nakul1010

Labels
ReviewNeeded The PR can be reviewed by peers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade to polkadot v1.0.0
3 participants
@nakul1010 @sander2 @gregdhill