You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From the documentation (e.g. the README, see below), one can easily infer that when the callback is called the payment is successful. I don't think the current implementation enforces that -- tests showed that in some condition the payment didn't complete (source account amount was decreased by the payment amount + fee but the destination account wasn't updated -- the money was held in escrow). We should make sure this is clear and maybe the return value should be a promise with a payment status?
From the documentation (e.g. the README, see below), one can easily infer that when the callback is called the payment is successful. I don't think the current implementation enforces that -- tests showed that in some condition the payment didn't complete (source account amount was decreased by the payment amount + fee but the destination account wasn't updated -- the money was held in escrow). We should make sure this is clear and maybe the return value should be a promise with a payment status?
The text was updated successfully, but these errors were encountered: